Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer error #5000

Merged
merged 3 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions internal/gatewayapi/securitypolicy.go
Original file line number Diff line number Diff line change
Expand Up @@ -962,10 +962,16 @@ func backendRefAuthority(resources *resource.Resources, backendRef *gwapiv1.Back
}
}

return net.JoinHostPort(
fmt.Sprintf("%s.%s", backendRef.Name, backendNamespace),
strconv.Itoa(int(*backendRef.Port)),
)
// Port is mandatory for Kubernetes services
if backendKind == resource.KindService {
return net.JoinHostPort(
fmt.Sprintf("%s.%s", backendRef.Name, backendNamespace),
strconv.Itoa(int(*backendRef.Port)),
)
}

// Fallback to the backendRef name, normally it's a unix domain socket in this case
return fmt.Sprintf("%s.%s", backendRef.Name, backendNamespace)
}

func (t *Translator) buildAuthorization(policy *egv1a1.SecurityPolicy) (*ir.Authorization, error) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,15 @@ backends:
- fqdn:
hostname: 'primary.foo.com'
port: 3000
- apiVersion: gateway.envoyproxy.io/v1alpha1
kind: Backend
metadata:
name: backend-uds
namespace: default
spec:
endpoints:
- unix:
path: '/var/run/uds.sock'
referenceGrants:
- apiVersion: gateway.networking.k8s.io/v1alpha2
kind: ReferenceGrant
Expand Down Expand Up @@ -179,7 +188,6 @@ securityPolicies:
extAuth:
http:
backendRef:
name: backend-fqdn
name: backend-uds
kind: Backend
group: gateway.envoyproxy.io
port: 3000
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,23 @@ backends:
reason: Accepted
status: "True"
type: Accepted
- apiVersion: gateway.envoyproxy.io/v1alpha1
kind: Backend
metadata:
creationTimestamp: null
name: backend-uds
namespace: default
spec:
endpoints:
- unix:
path: /var/run/uds.sock
status:
conditions:
- lastTransitionTime: null
message: The Backend was accepted
reason: Accepted
status: "True"
type: Accepted
gateways:
- apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
Expand Down Expand Up @@ -322,8 +339,7 @@ securityPolicies:
backendRef:
group: gateway.envoyproxy.io
kind: Backend
name: backend-fqdn
port: 3000
name: backend-uds
targetRef:
group: gateway.networking.k8s.io
kind: HTTPRoute
Expand Down Expand Up @@ -526,14 +542,15 @@ xdsIR:
security:
extAuth:
http:
authority: primary.foo.com:3000
authority: backend-uds.default
destination:
name: securitypolicy/default/policy-for-http-route-3-http-backendref/extauth/0
settings:
- addressType: FQDN
- addressType: IP
endpoints:
- host: primary.foo.com
port: 3000
- host: ""
path: /var/run/uds.sock
port: 0
protocol: HTTP
weight: 1
path: ""
Expand Down
1 change: 1 addition & 0 deletions release-notes/current.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ new features: |

# Fixes for bugs identified in previous versions.
bug fixes: |
Fixed a nil pointer error that occurs when a SecurityPolicy refers to a UDS backend

# Enhancements that improve performance.
performance improvements: |
Expand Down
Loading