fix: dont shift listener ports for Standalone mode #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5027 +/- ##
==========================================
- Coverage 66.78% 66.78% -0.01%
==========================================
Files 209 209
Lines 32362 32366 +4
==========================================
+ Hits 21614 21616 +2
- Misses 9446 9448 +2
Partials 1302 1302 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Jan 10, 2025
Fixes: envoyproxy#4981 Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
zirain
force-pushed
the
standalone-port
branch
from
728f293 to
4af2315
Compare
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Jan 10, 2025
* fix: dont shift listener ports for Standalone mode Fixes: envoyproxy#4981 Signed-off-by: Arko Dasgupta <[email protected]> * test Signed-off-by: Arko Dasgupta <[email protected]> * fix lint Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 84f2ad2) Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
added a commit
that referenced
this pull request
Jan 14, 2025
* fix: nil pointer error (#5000) * fix: nil pointer error Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 10a31f1) Signed-off-by: Huabing Zhao <[email protected]> * fix: store one copy of HTTPRoute Extension Filters (#5002) * fix: store one copy of HTTPRoute Extension Filters Signed-off-by: Guy Daich <[email protected]> * fix code review comments Signed-off-by: Guy Daich <[email protected]> * check if httproutefilter crd exists Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 2a5ecaf) Signed-off-by: Huabing Zhao <[email protected]> * fix: enable ipv4 compat mode for dual stack cluster support (#5018) enable ipv4 compat mode for dual stack cluster support Signed-off-by: Will Tekulve <[email protected]> (cherry picked from commit e028254) Signed-off-by: Huabing Zhao <[email protected]> * fix: explicitly set ip family and family policy in gateway spec (#5019) * explicitly set ip family and family policy Signed-off-by: Will Tekulve <[email protected]> * add TestService cases Signed-off-by: Will Tekulve <[email protected]> (cherry picked from commit 4d5d3f0) Signed-off-by: Huabing Zhao <[email protected]> * fix: check before setting cookie TTL in sessionPersistence (#5026) * Check before setting Cookie TTL in Session Persistence Fixes a null ptr exception when the cookie ttl is nil but was being accessed without checking if its valid or not Signed-off-by: Arko Dasgupta <[email protected]> * simplify logic Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit dff0531) Signed-off-by: Huabing Zhao <[email protected]> * fix: dont shift listener ports for Standalone mode (#5027) * fix: dont shift listener ports for Standalone mode Fixes: #4981 Signed-off-by: Arko Dasgupta <[email protected]> * test Signed-off-by: Arko Dasgupta <[email protected]> * fix lint Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 84f2ad2) Signed-off-by: Huabing Zhao <[email protected]> * fix: shutdown-manager not respecting security context of container spec (#4938) * Fix shutdown-manager not respecting security context of container spec Signed-off-by: Dean Coakley <[email protected]> * Update securityContext testdata Signed-off-by: Dean Coakley <[email protected]> * Lint with gci Signed-off-by: Dean Coakley <[email protected]> --------- Signed-off-by: Dean Coakley <[email protected]> (cherry picked from commit 43621b4) Signed-off-by: Huabing Zhao <[email protected]> * fix: use tls config from BTP when connecting to the OIDC provider's well-known endpoint. (#4857) * add e2e test for OIDC provider with TLS Signed-off-by: Huabing Zhao <[email protected]> * delete file Signed-off-by: Huabing Zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> * use TLS config from BTLPolicy to fetch auth endpoint Signed-off-by: Huabing Zhao <[email protected]> * refactor Signed-off-by: Huabing Zhao <[email protected]> * update release note Signed-off-by: Huabing Zhao <[email protected]> * update release note Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit 3a39c35) Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Will Tekulve <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Dean Coakley <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Will Tekulve <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Dean Coakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4981