Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add backend support for GRPCRoute/TCPRoute/UDPRoute #5038

Merged
merged 2 commits into from
Jan 15, 2025
Merged

feat: add backend support for GRPCRoute/TCPRoute/UDPRoute #5038

merged 2 commits into from
Jan 15, 2025

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Jan 13, 2025 •
edited
Loading

This PR introduces Backend support for GRPCRoute, TCPRoute, and UDPRoute.

Implements: #3509 #4036 #4038
Release Notes: Yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 13, 2025 03:22
@zhaohuabing zhaohuabing marked this pull request as draft January 13, 2025 03:23
@zhaohuabing zhaohuabing changed the title add backend support for GRPCRoute/TCPRoute/UDPRoute feat: add backend support for GRPCRoute/TCPRoute/UDPRoute Jan 13, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.71%. Comparing base (743e5e0) to head (c440cca).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/route.go 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5038      +/-   ##
==========================================
- Coverage   66.76%   66.71%   -0.05%     
==========================================
  Files         211      211              
  Lines       32811    32799      -12     
==========================================
- Hits        21905    21881      -24     
- Misses       9580     9588       +8     
- Partials     1326     1330       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing force-pushed the backend branch 2 times, most recently from 9850d1c to 4f6e935 Compare January 13, 2025 08:04
@zhaohuabing zhaohuabing marked this pull request as ready for review January 13, 2025 08:04
@zhaohuabing zhaohuabing marked this pull request as draft January 14, 2025 00:30
@zhaohuabing
fix e2e
c440cca 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing marked this pull request as ready for review January 14, 2025 08:10
arkodg
arkodg approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team January 14, 2025 21:58
guydc
guydc approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guydc guydc merged commit 8b89dad into envoyproxy:main Jan 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@guydc guydc guydc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaohuabing @arkodg @guydc