Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qubes: Do not open document previewer on error #581

Closed
apyrgio opened this issue Oct 5, 2023 · 0 comments · Fixed by #582
Closed

Qubes: Do not open document previewer on error #581

apyrgio opened this issue Oct 5, 2023 · 0 comments · Fixed by #582
Labels
bug Something isn't working P:Qubes QubesOS integration
Milestone
0.5.0

Comments

@apyrgio
Copy link
Contributor

apyrgio commented Oct 5, 2023

During our experiments, we have seen that some failed conversions on Qubes lead to opening the document viewer regardless. Since the safe document does not exist, the user just sees the following error:

Screenshot_2023-10-03_15-56-21
@apyrgio apyrgio added bug Something isn't working P:Qubes QubesOS integration labels Oct 5, 2023
@apyrgio apyrgio added this to the 0.5.0 milestone Oct 5, 2023
apyrgio added a commit that referenced this issue Oct 5, 2023
@apyrgio
Do not show file previews in case of exceptions
ea1aad8 
If a Qubes conversion encounters an exception that is not a subclass of
ConversionException, it will still show a preview of a file that does
not exist.

Send an error progress report in that case, so that the GUI code can
detect that an error occurred and not open a file preview

Fixes #581
@apyrgio apyrgio mentioned this issue Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P:Qubes QubesOS integration
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Do not show file previews in case of exceptions freedomofpress/dangerzone
1 participant
@apyrgio