Disable HWP / HWPX conversion on MacOS M1 / Qubes #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeplow
approved these changes
Aug 5, 2023
Factor out the MIME type detection logic, so that we can use it both in Qubes and containers.
Sometimes, LibreOffice returns with status code 0, but in reality, it fails. It doesn't create a file, and Dangerzone does not detect this. What happens next is that it fails in the next command, and throws an unrelated error. Detect that LibreOffice fails, by checking if the output file exists, after the PDF conversion.
The HWP / HWPX conversion feature does not work on the following platforms: * MacOS with Apple Silicon CPU * Native Qubes OS For this reason, we need to: 1. Disable it on the GUI side, by not allowing the user to select these files. 2. Throw an error on the isolation provider side, in case the user directly attempts to convert the file (either through CLI or via "Open With"). Refs #494 Refs #498
deeplow
force-pushed
the
494-disable-hwp
branch
from
f4de176 to
e3a8a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HWP / HWPX conversion feature does not work on the following
platforms:
For this reason, we need to:
files.
directly attempts to convert the file (either through CLI or via
"Open With").
Refs #494
Refs #498