Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some phpstan issues #2393

Merged
merged 24 commits into from
Mar 13, 2019
Merged

Some phpstan issues #2393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
cfdb2dc
Fix bug, method init must be protected
belgattitude Mar 1, 2019
cf8a062
Added phpstan level 0
belgattitude Mar 1, 2019
77c165e
Added exclusions
belgattitude Mar 1, 2019
5247427
Fix: incorrect case in Twig_SimpleFunction
belgattitude Mar 1, 2019
1ba1ed1
Fix, no abstract properties, if properties used in methods let's set …
belgattitude Mar 1, 2019
b11bd1a
Fixed Psr\SimpleCache\InvalidArgumentException referenced with incorr…
belgattitude Mar 1, 2019
9294168
added exclusions
belgattitude Mar 1, 2019
35c0fd9
Fixed: Access to an undefined property Grav\Framework\Form\FormFlash:…
belgattitude Mar 1, 2019
bae64f6
Fixed: does not call parent constructor from Grav\Common\Iterator.
belgattitude Mar 1, 2019
5b2759b
Fixed: does not call parent constructor from Grav\Common\Iterator.
belgattitude Mar 1, 2019
c1cd878
Fixed: does not call parent constructor
belgattitude Mar 1, 2019
2eac057
Fixed: does not call parent constructor
belgattitude Mar 1, 2019
08a923d
Minor: correct type for inflector
belgattitude Mar 2, 2019
f0b6d3e
Moved phpstan.neon out of public directory
belgattitude Mar 2, 2019
8a17ff6
Added exclusion
belgattitude Mar 2, 2019
7849398
set GRAV_USER_INSTANCE to prevent LogiException in User
belgattitude Mar 2, 2019
ae95fc0
Exlude Stream:create
belgattitude Mar 2, 2019
2273e27
Minor: Missing storage property
belgattitude Mar 2, 2019
4c4330e
Minor: Fixed missing properties (phpstan level 1)
belgattitude Mar 2, 2019
b37467e
Added type for $data
belgattitude Mar 2, 2019
72e9bef
Minor: Ensure $langs is initialized
belgattitude Mar 2, 2019
ac663ca
Fix possible bug in $http_response_header status code retrieval (PHP …
belgattitude Mar 2, 2019
a530481
Added exclusion for $http_response_header (isset is actually not requ…
belgattitude Mar 2, 2019
f5fbcfa
Strict null check
belgattitude Mar 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@
},
"require-dev": {
"codeception/codeception": "^2.4",
"phpstan/phpstan": "^0.11",
"phpstan/phpstan-strict-rules": "^0.11",
"phpunit/php-code-coverage": "~6.0",
"fzaninotto/faker": "^1.8",
"victorjonsson/markdowndocs": "dev-master"
Expand Down Expand Up @@ -80,6 +82,7 @@
},
"scripts": {
"post-create-project-cmd": "bin/grav install",
"phpstan": "vendor/bin/phpstan analyse -l 0 -c ./tests/phpstan/phpstan.neon system/src",
"test": "vendor/bin/codecept run unit",
"test-windows": "vendor\\bin\\codecept run unit"
},
Expand Down
Loading