feat(core)!: Stop setting user in requestDataIntegration
#14898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
chargome
approved these changes
Jan 3, 2025
mydea
force-pushed
the
fn/no-request-user
branch
from
c9b05b2 to
0e88cce
Compare
Lms24
approved these changes
Jan 7, 2025
This was an express-specific, rather undocumented behavior, and also conflicted with our privacy-by-default stance. Starting in v9, you'll need to manually call `Sentry.setUser()` e.g. in a middleware to set the user on Sentry events. Docs for this are already pending: getsentry/sentry-docs#12224
mydea
force-pushed
the
fn/no-request-user
branch
from
0e88cce to
9ab9e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an express-specific, rather undocumented behavior, and also conflicted with our privacy-by-default stance.
Starting in v9, you'll need to manually call
Sentry.setUser()e.g. in a middleware to set the user on Sentry events.Docs for this are already pending: getsentry/sentry-docs#12224
Extracted this out of #14806