Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve connection logging to indicate the usage. #461

Closed
sjmudd opened this issue Jul 26, 2017 · 2 comments · Fixed by #515
Closed

Improve connection logging to indicate the usage. #461

sjmudd opened this issue Jul 26, 2017 · 2 comments · Fixed by #515
Assignees

Comments

@sjmudd
Copy link

sjmudd commented Jul 26, 2017

I have been testing gh-ost and notice it may make several different types of connections to different servers. That may lead to confusion if you have a lot. Therefore I think it would be good to identify: the "writer" connection, the "reader" (when you're running against a replica) and even the "monitoring" connections.

e.g.

2017-07-26 11:02:40 INFO connection validated on myreplica.example.com:3306

maybe could be:

2017-07-26 11:02:40 INFO inspector connection validated on myreplica.example.com:3306

(or similar)

and similarly adjust the entries for the connections used for writing and any other read handles you make.

@shlomi-noach shlomi-noach self-assigned this Jul 26, 2017
@akshaychhajed
Copy link
Contributor

If this involves reviewing code and modifying log statements, I can give this a shot.

@tomkrouper
Copy link

@akshaychhajed, please, give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants