Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved connection type logging #515

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

akshaychhajed
Copy link
Contributor

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #461

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR adds connection type to logs. It helps distinguish connection type (inspector, streamer and applier)
Fixes #461

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt
Copy link
Collaborator

@akshaychhajed thanks for your contribution and sorry for the delay

Could you resolve the merge conflicts with this PR above? I can test and merge this PR once the changes are up-to-date

@akshaychhajed
Copy link
Contributor Author

@timvaillancourt looks like I am little late for this. Let me know if I can help.

Copy link
Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timvaillancourt
Copy link
Collaborator

@timvaillancourt looks like I am little late for this. Let me know if I can help.

@akshaychhajed I've fixed the merge conflicts and this change LGTM 👍. Thanks!

@timvaillancourt timvaillancourt merged commit 62ce678 into github:master Feb 8, 2021
timvaillancourt added a commit that referenced this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve connection logging to indicate the usage.
2 participants