Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle "query_shard_exception" in OpenSearch error handling #3272

Conversation

jaegeral
Copy link
Collaborator

This pull request enhances the error handling for OpenSearch queries to include specific handling for the "query_shard_exception" error. Previously, only the "too_many_nested_clauses" error was handled explicitly. This change ensures that "query_shard_exception" is also caught, displayed to the user and logged appropriately, allowing for more informative error reporting and potential future recovery logic.

Specifically:

  • Modified the error handling logic in EventList to include a check for the "query_shard_exception" message.

This change improves the robustness of the OpenSearch integration by providing more granular error handling. It does not introduce any new functionality or change existing behavior other than improved error reporting.

It does not fix the underlying issue.

@jaegeral jaegeral requested a review from jkppr January 31, 2025 08:31
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@jaegeral jaegeral merged commit cab8ee2 into google:master Jan 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants