Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update client.files.upload usage in README #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrMebelMan
Copy link

@MrMebelMan MrMebelMan commented Feb 7, 2025

I've been trying out the file uploads API and noticed that the file upload examples from README don't work.

file = client.files.upload(path='a11.txt') # throws an exception

According to https://github.com/googleapis/python-genai/blob/main/google/genai/files.py#L788, the correct path argument is not path anymore, but file.

file = client.files.upload(file='a11.txt') # works

There's a similar PR, but I've signed the CLA and fixed all wrong parameter occurances.

Copy link

google-cla bot commented Feb 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MrMebelMan MrMebelMan force-pushed the fix/file_upload_docs branch 2 times, most recently from 3616ba6 to f07d9fb Compare February 11, 2025 09:18
@MrMebelMan MrMebelMan closed this Feb 13, 2025
@MrMebelMan MrMebelMan deleted the fix/file_upload_docs branch February 13, 2025 13:09
@MrMebelMan MrMebelMan reopened this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant