Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow protobuf 5.x #1144

Merged
merged 10 commits into from
Jul 12, 2024
Merged

fix: Allow protobuf 5.x #1144

merged 10 commits into from
Jul 12, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented May 24, 2024 •
edited by parthea
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 649277844

BEGIN_COMMIT_OVERRIDE
fix: Allow protobuf 5.x
feat: Add support for Cloud Spanner Scheduled Backups
feat: Add field order_by in spanner.proto
feat: Add field lock_hint in spanner.proto
END_COMMIT_OVERRIDE

Source-Link: googleapis/googleapis@fd7efa2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/50be251329d8db5b555626ebd4886721f547d3cc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9

BEGIN_NESTED_COMMIT
chore: Update gapic-generator-python to v1.18.0
PiperOrigin-RevId: 638650618

Source-Link: googleapis/googleapis@6330f03

Source-Link: https://github.com/googleapis/googleapis-gen/commit/44fa4f1979dc45c1778fd7caf13f8e61c6d1cae8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add field order_by in spanner.proto
feat: add field lock_hint in spanner.proto

PiperOrigin-RevId: 636759139

Source-Link: googleapis/googleapis@eeed69d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8b4c5dae2157cd683a9229d40de8c71665c21a0a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGI0YzVkYWUyMTU3Y2Q2ODNhOTIyOWQ0MGRlOGM3MTY2NWMyMWEwYSJ9
END_NESTED_COMMIT

@gcf-owl-bot
feat: add field order_by in spanner.proto
e7c3ed9 
feat: add field lock_hint in spanner.proto

PiperOrigin-RevId: 636759139

Source-Link: googleapis/googleapis@eeed69d

Source-Link: googleapis/googleapis-gen@8b4c5da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGI0YzVkYWUyMTU3Y2Q2ODNhOTIyOWQ0MGRlOGM3MTY2NWMyMWEwYSJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label May 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review May 24, 2024 04:55
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 24, 2024 04:55
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels May 24, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2024
@gcf-owl-bot
chore: Update gapic-generator-python to v1.18.0
4ba0741 
PiperOrigin-RevId: 638650618

Source-Link: googleapis/googleapis@6330f03

Source-Link: googleapis/googleapis-gen@44fa4f1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: add field order_by in spanner.proto chore: Update gapic-generator-python to v1.18.0 May 30, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels May 30, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 30, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 30, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Jul 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 4, 2024 06:54
@gcf-owl-bot gcf-owl-bot bot requested a review from rsamborski July 4, 2024 06:54
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@parthea parthea changed the title feat(spanner): Add support for Cloud Spanner Scheduled Backups chore: Update gapic-generator-python to v1.18.0 Jul 4, 2024
@parthea parthea changed the title chore: Update gapic-generator-python to v1.18.0 fix: allow protobuf 5.x Jul 4, 2024
@parthea parthea changed the title fix: allow protobuf 5.x fix: Allow protobuf 5.x Jul 4, 2024
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 4, 2024
@parthea
Copy link
Contributor

parthea commented Jul 4, 2024 •
edited
Loading

Adding do not merge label as additional changes are needed to support protobuf 5.x Done

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2024
@parthea parthea assigned harshachinta and unassigned hengfengli Jul 8, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@parthea
Copy link
Contributor

parthea commented Jul 12, 2024

The failing Kokoro Prerelease Dependencies presubmit is tracked in #1159

@parthea parthea merged commit 9609ad9 into main Jul 12, 2024
14 of 16 checks passed
@parthea parthea deleted the owl-bot-copy branch July 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

@rsamborski rsamborski Awaiting requested review from rsamborski rsamborski is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the googleapis/python-spanner API. owl-bot-copy owlbot:run Add this label to trigger the Owlbot post processor. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @harshachinta @hengfengli @yoshi-kokoro