Order invoice price incl tax check #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c66b7a.
Bugfix/nullcheck
Bundledproduct with attributes
check if the blob exists before returning the URL
| @{ | ||
| var logoPicture = await _pictureService.GetPictureById(_pdfSettings.LogoPictureId); | ||
| var logoExists = logoPicture != null; | ||
| var limitbyVendor = !string.IsNullOrEmpty(Model.Item2); | ||
| var limitbyVendor = !string.IsNullOrEmpty(Model.Item2); | ||
| var priceIncludesTax = workContext.TaxDisplayType == TaxDisplayType.IncludingTax; |
There was a problem hiding this comment.
TaxDisplayType should get from the Order
There was a problem hiding this comment.
@KrzysztofPajak updated code as per feedback
| @@ -87,6 +88,7 @@ | |||
| string paymentMethodStr = paymentMethod != null ? paymentMethod.FriendlyName : order.PaymentMethodSystemName; | |||
| } | |||
| <li>@(string.Format(_translationService.GetResource("PDFInvoice.PaymentMethod", order.CustomerLanguageId), paymentMethodStr))</li> | |||
| @await Component.InvokeAsync("Widget", new { widgetZone = "payment_method_below", additionalData = @order.Id }) | |||
There was a problem hiding this comment.
Please change the name for the widget zone, better name will be i.e: pdf_payment_method_below
There was a problem hiding this comment.
@KrzysztofPajak updated the zone name
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #294 #295
Type: bugfix
Issue
1.In order invoice PDF unit price, item price , subtotal amount and discount price is configured with including tax property's, This leads confusion to customer.
2. Header text and footer are coming with some junk characters in PDF.
Solution
1.For all the above prices added check to include or exclude tax based on CustomerTaxDisplayTypeId from order details .
2.Decoded header text and footer text with Html.Raw attribute to avoid junk characters.
Breaking changes
None
Testing