Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sax battery #6605

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

matfroh
Copy link
Contributor

@matfroh matfroh commented Feb 21, 2025

Proposed change

The custom component SAX battery will add the SAX battery storage into homeassistant, enabling polling of data but as well managing the charge and the discharge of the battery.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @matfroh 👋

Thanks for opening a pull request. However, the provided link, links to a repository with some Python code, but doesn't seem to contain a working Home Assistant integration.

Could you please point me to the codebase that holds this integration?

Thanks!

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 21, 2025 18:44
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@matfroh
Copy link
Contributor Author

matfroh commented Feb 22, 2025

hi @frenck , apologies, code has now been uploaded at this place: https://github.com/matfroh/sax_battery_ha

@matfroh matfroh requested a review from frenck February 22, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants