Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mill issue, where no sensors were shown #137521

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix Mill issue, where no sensors were shown #137521

merged 1 commit into from
Feb 6, 2025

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Feb 6, 2025

Breaking change

Proposed change

Fix Mill issue, where no sensors were shown
Fix mill issue #137477
A bug introduced when the base class was added: #134415

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Danielhiversen 👍

Can you update the PR title to be descriptive? We don't have to reference the issue ID in the title (more importantly, that context will be lost once it is going outside of GitHub, e.g., changelogs on our website).

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 07:46
@home-assistant
Copy link

home-assistant bot commented Feb 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Danielhiversen Danielhiversen changed the title Fix mill issue #137477 Fix Mill issue, where none sensors where available Feb 6, 2025
@Danielhiversen Danielhiversen changed the title Fix Mill issue, where none sensors where available Fix Mill issue, where no sensors were available Feb 6, 2025
@Danielhiversen Danielhiversen marked this pull request as ready for review February 6, 2025 08:57
@home-assistant home-assistant bot requested a review from frenck February 6, 2025 08:58
@Danielhiversen Danielhiversen changed the title Fix Mill issue, where no sensors were available Fix Mill issue, where no sensors were shown Feb 6, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Danielhiversen 👍

../Frenck

@frenck frenck merged commit 4deffb2 into dev Feb 6, 2025
31 of 32 checks passed
@frenck frenck deleted the fix_#137477 branch February 6, 2025 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mill GL-WIFI Socket G3 lost all sensors after last core update 2025.2.0
2 participants