Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx console errors in charts #24048

Merged
merged 2 commits into from
Feb 3, 2025
Merged

FIx console errors in charts #24048

merged 2 commits into from
Feb 3, 2025

Conversation

MindFreeze
Copy link
Contributor

Proposed change

The issue was that we fully replaced chart component configs and that caused components to be recreated while they are in use. For example while zooming.

Also added a tweak to turn off zooming when reset is pressed. So when you zoom in while the window is not focused, then press reset, zooming is disabled until you press the modifier key. This still doesn't cover all cases of unfocused window but it's something.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze added this to the 2025.2 milestone Feb 3, 2025
@bramkragten bramkragten merged commit 64a9685 into dev Feb 3, 2025
15 checks passed
@bramkragten bramkragten deleted the chart-errors branch February 3, 2025 17:13
bramkragten pushed a commit that referenced this pull request Feb 3, 2025
* FIx console errors in charts

* handle undefined unit_of_measurement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: e is undefined value
2 participants