-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
motionEye: update tap action keywords in example #37413
Conversation
- to reflect current software - using keywords as described in https://www.home-assistant.io/dashboards/actions/#action
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis change revises the YAML configuration for the Home Assistant motionEye integration by updating the action calls used for camera control. The previous structure that used Changes
Sequence Diagram(s)sequenceDiagram
participant HA as Home Assistant
participant ME as motionEye Integration
participant Cam as Camera Device
HA->>ME: Initiate camera action (move left/right/up/down)
Note over ME: Process using new perform-action structure
ME->>Cam: Execute action (using perform-action / perform_action)
Cam-->>ME: Return execution confirmation
ME-->>HA: Relay action result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/motioneye.markdown (1)
304-306
: Consider using a consistent action key format.The configuration uses both
action: perform-action
andperform_action: motioneye.action
, which seems redundant. Consider using either:
- Just
action: call-service
withservice: motioneye.action
, or- Just
action: motioneye.action
This would make the configuration more concise and easier to understand.
- action: perform-action - perform_action: motioneye.action + action: call-service + service: motioneye.action
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/motioneye.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/motioneye.markdown (1)
312-314
: Apply consistent action format across all tap actions.The same action format inconsistency appears in all tap action configurations. Apply the same solution suggested above to all instances to maintain consistency throughout the example.
Also applies to: 320-322, 328-330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @c0ffeeca7 👍
../Frenck
- to reflect current software - using keywords as described in https://www.home-assistant.io/dashboards/actions/#action
- to reflect current software - using keywords as described in https://www.home-assistant.io/dashboards/actions/#action
Proposed change
motionEye: update tap action keywords in example
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit