Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AutoTLS): enabled by default with 1h RegistrationDelay #10724

Merged
merged 9 commits into from
Feb 25, 2025
Merged

feat(AutoTLS): enabled by default with 1h RegistrationDelay #10724

merged 9 commits into from
Feb 25, 2025

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 19, 2025 •
edited
Loading

Enables AutoTLS by default, but delays registration by 1h if user did not explicitly set AutoTLS.Enabled to true

Depends on ipshipyard/p2p-forge#58

TODO

  • feat(client): WithRegistrationDelay ipshipyard/p2p-forge#58
  • enable AutoTLS by default
  • delay implicit default AutoTLS registration by AutoTLS.RegistrationDelay=1h
  • fix tests
  • set AutoTLS.Enabled=false in test profile
  • switch to p2p-forge/client v0.4.0 release
  • update docs/config.md
    • remove EXPERIMENTAL messaging
    • de-emphasize manual configuration
  • add highlight to 0.34 changelog

Close #10560

@lidel
feat(autotls): enable with RegistrationDelay
61d9843 
Enables AutoTLS by default, but delays registration by 1h
if user did not explicitly set `AutoTLS.Enabled` to `true`
@lidel lidel changed the title feat(autotls): enable with RegistrationDelay feat(AutoTLS): enabled by default with RegistrationDelay Feb 20, 2025
lidel added 5 commits February 20, 2025 02:36
@lidel
docs: AutoTLS.RegistrationDelay
539f965
@lidel
fix(ux): log ERROR when AutoTLS is disabled
9b6e157 
hard fail when TCP or Websocket is not present is a bad UX + explodes
complexity of tests.

instead, we log user-friendly ERROR and disable AutoTLS when
there is no /tcp, no Websocket transport, or PNET is used with default
settings
@lidel
docs: changelog
b519c16
@lidel
test: fix TestIface/Routing/TestRoutingFindPeer
5a7f57b
@lidel
fix: disable AutoTLS in test profile
78766ea
@lidel lidel requested review from 2color and aschmahmann February 21, 2025 01:19
@lidel lidel changed the title feat(AutoTLS): enabled by default with RegistrationDelay feat(AutoTLS): enabled by default with 1h RegistrationDelay Feb 21, 2025
@lidel lidel marked this pull request as ready for review February 21, 2025 01:41
@lidel lidel requested a review from a team as a code owner February 21, 2025 01:42
lidel
lidel commented Feb 25, 2025
View reviewed changes
Copy link
Member Author

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dry-run looking ok, merging

@lidel
Copy link
Member Author

lidel commented Feb 25, 2025 •
edited
Loading

Switched to released p2p-forge/client v0.4.0 + smoke tested here and in libp2p/go-libp2p#3211.
Did not get feedback on docs, but assuming good enough – feel free to refine in separate PR.

Merging to give this a try in 0.34.0-rc1

@lidel lidel merged commit d6a5bc0 into master Feb 25, 2025
16 checks passed
@lidel lidel deleted the autotls-implicit-default-enable-iff branch February 25, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2color 2color Awaiting requested review from 2color

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling AutoTLS feature by default
1 participant
@lidel