fix(client): DNS-01 TXT record check #57
Merged
+104
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly implements `Wait` and does not proceed with ACME if TXT record is not present and does not include the expected value. this will lower the numberof failed registrations and retries + allows us to remove 5s sleep
lidel
force-pushed
the
acme-dns-01-fixes
branch
from
a689e16 to
a3e3ff3
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
lidel
commented
Feb 25, 2025
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Waitinp2p-forge/clientand does not proceed with ACME if TXT recordis not present and does not include the expected value.
The goal is to lower the number of failed registrations and retries + allows us to remove 5s sleep and usually finish successful registration under 1 second.
Waitprobing real TXT record's presence and value, with backofffiledirective in e2e tests (avoid future regressions if upstream impl. offileplugin starts acting as catch-all)