-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcsh: Fix autocompletion for no single-hyphen args #112
tcsh: Fix autocompletion for no single-hyphen args #112
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 91.06% 90.88% -0.19%
==========================================
Files 3 3
Lines 347 351 +4
==========================================
+ Hits 316 319 +3
- Misses 31 32 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break things a little (at least on bash
).
before:
main$ eval "$(PYTHONPATH=. python examples/customcomplete.py completion bash)"
main$ customcomplete <TAB>
completion process
after:
fix-singlehyphen$ eval "$(PYTHONPATH=. python examples/customcomplete.py completion bash)"
fix-singlehyphen$ customcomplete <TAB>
fix-singlehyphen$ customcomplete completion <TAB>
fix-singlehyphen$ customcomplete completion bash
That's weird, I only changed the csh function, and this commit to avoid test failures. I should rebase and retest this. |
be2eed3
to
5f678ec
Compare
Rebased and re-tested, including that test you mentioned, works for me. |
Sounds like the test failure is not my fault, |
336c7ad
to
d73a29e
Compare
Thanks! Rebased now over #139 (should merge that first). Better now? |
LGTM, you can merge this. |
If the parser has no single-hyphen options, the tcsh template would generate a syntax error. Include a hack to that the autocompletion for the double-hyphen selection does not add an extra space at the end.
- Document "root_prefix" non-usage - Use raw strings if possible - Sort options (cosmetic)
d73a29e
to
5a8d3ea
Compare
5a8d3ea
to
ce9ea94
Compare
ce9ea94
to
3df3b2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; thanks!
I removed the examples/doublecomplete.py
since it seems more about debugging/testing.
Maybe worth adding a follow-up test (in tests/test_shtab.py
) instead.
If the parser has no single-hyphen options, the tcsh template would
generate a syntax error.
Include a hack to that the autocompletion for the double-hyphen
selection does not add an extra space at the end.
Another fix to the tcsh template support, see #56 #57 #58