fix: wrapper install now also copies jbang.ps1
#1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't copy this before because having just `jbang.cmd` was thought to be enough for Windows. But some time ago we actually removed all installation code from the batch file and delegate any installation requirements to the .ps1 file. So the wrapper installation was missing a file on Windows. Fixes jbangdev#1386
Codecov Report
@@ Coverage Diff @@
## main #1391 +/- ##
============================================
- Coverage 56.99% 56.97% -0.02%
Complexity 1206 1206
============================================
Files 104 104
Lines 6281 6283 +2
Branches 1034 1034
============================================
Hits 3580 3580
- Misses 2220 2222 +2
Partials 481 481
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't copy this before because having just
jbang.cmdwas thoughtto be enough for Windows. But some time ago we actually removed all
installation code from the batch file and delegate any installation
requirements to the .ps1 file. So the wrapper installation was missing
a file on Windows.
Fixes #1386