Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix vscode icon #1905

Merged
merged 5 commits into from
Jan 16, 2025
Merged

docs: fix vscode icon #1905

merged 5 commits into from
Jan 16, 2025

Conversation

wfouche
Copy link
Contributor

@wfouche wfouche commented Jan 12, 2025

Fix vscode icon

Closes #1904

@wfouche wfouche changed the title (docs) fix vscode icon docs: fix vscode icon Jan 12, 2025
@maxandersen
Copy link
Collaborator

thanks for noticing the issue but if simpleicons can't keep their vscode icon then I can't see us add it to our repo either.

see simple-icons/simple-icons#11236

not sure what a good solution is here.

@wfouche
Copy link
Contributor Author

wfouche commented Jan 16, 2025

Alternatively, the main focus could shift to VSCodium and we provide Visual Studio Code as a secondary option.

image

@maxandersen
Copy link
Collaborator

perfect - if microsoft doesn't want us to show their logos its their loss :)

@maxandersen maxandersen merged commit f80695f into jbangdev:main Jan 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vscode icon not displayed in the documentation
2 participants