Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Entra profile photo with Jenkins avatar #658

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

timja
Copy link
Member

@timja timja commented Feb 2, 2025

image

I lifted a fair bit of code from https://github.com/jenkinsci/avatar-plugin.

cc @janfaracik

Testing done

  1. With profile photo configured in Entra ID - success
  2. Without profile photo - success
  3. Able to override Entra avatar with avatar plugin - success after Raise priority of this plugin in resolving avatars avatar-plugin#11

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit 26fb299 into jenkinsci:master Feb 2, 2025
16 checks passed
@timja timja deleted the avatar branch February 2, 2025 22:53
timja added a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant