Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up Manage Old Data UI #11

Open
janfaracik opened this issue Feb 18, 2025 · 12 comments · May be fixed by jenkinsci/jenkins#10320
Open

Tidy up Manage Old Data UI #11

janfaracik opened this issue Feb 18, 2025 · 12 comments · May be fixed by jenkinsci/jenkins#10320

Comments

@janfaracik
Copy link
Contributor

janfaracik commented Feb 18, 2025 •
edited
Loading

What feature do you want to see added?

This page is a little messy and confusing. It shows tables even when there's nothing in them - it could be simplified in a similar fashion to the other settings pages.

Image
Image

Upstream changes

No response

Are you interested in contributing this feature?

No response
@timja
Copy link
Member

timja commented Feb 18, 2025

An empty state would make sense. Similar to no plugin updates available

@SohamJuneja
Copy link

Image
Does this seem fine?
Added a condition to check if it.data.entrySet() is empty before rendering the table, preventing unnecessary empty tables from being displayed.

@timja
Copy link
Member

timja commented Feb 21, 2025

Probably something more like this: jenkinsci/csp-plugin#16

@SohamJuneja
Copy link

Image
This?

@timja
Copy link
Member

timja commented Feb 21, 2025

Yes that's looking better, it should have an icon though and not an X.

Check what the plugin update page shows when no plugin updates are available

@SohamJuneja
Copy link

Image

@janfaracik
Copy link
Contributor Author

Use the 'Manage Old Data' icon rather than the plugin one.

@SohamJuneja
Copy link

SohamJuneja commented Feb 21, 2025 •
edited
Loading

I'm not certain which icon specifically represents the 'Manage Old Data' feature. Is it something like 'symbol-notepad', 'icon-document', or another specific Jenkins icon identifier? @timja @janfaracik

@timja
Copy link
Member

timja commented Feb 22, 2025

Its symbol-trash-bin

@SohamJuneja
Copy link

Thanks @timja

Image
Is this fine now? Shall I create a PR for this?

@timja
Copy link
Member

timja commented Feb 23, 2025

Yes go for it

@SohamJuneja SohamJuneja linked a pull request Feb 23, 2025 that will close this issue
Open
14 tasks
@SohamJuneja
Copy link

Sure , thanks for the help @janfaracik @timja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add empty state for no old data SohamJuneja/jenkins
3 participants
@timja @janfaracik @SohamJuneja