feat: Add empty state for no old data

[SohamJuneja]

Fixes jenkinsci/sig-ux#11.
Added an empty state to Manage Old Data to not display an empty table , instead show No old data was found.

Testing done

Before:

After:

Proposed changelog entries

• Add an empty state to Manage Old Data page

Proposed changelog category

/label rfe

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@timja @janfaracik

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

UI looks good, jelly just needs a little polish

[SohamJuneja]

@timja I've made some changes to the Jelly file , please check now

[timja]

@timja I've made some changes to the Jelly file , please check now

change looks good but you haven't done https://github.com/jenkinsci/jenkins/pull/10320/files#r1966735160

[SohamJuneja]

@timja yup , sorry I missed that earlier , done it now.

[SohamJuneja]

@timja made the change now , is it fine?

[timja]

LGTM

[mawinter69]

I don't think that the implementation is complete. While looping over the elements of the table it does the check item.value != ''. If this evaluates to false then nothing is added to the table but the hasExtra var is set eventually. So what could happen is that the table is empty because all elements go in the otherwise part and the table for hasExtra is shown.
That's exactly what you can see on the initial screenshot in the linked issue.

[mawinter69]

Maybe one can already have a flag when the data is collected whether the table would be empty and the hasExtra will be set.

Markus found a bug

[mawinter69]

/label web-ui

[SohamJuneja]

@mawinter69 I've made the desired changes as you suggested

[mawinter69]

I think it looks good now.
Ideally perform the following test:

• setup a new Jenkins from scratch without any plugins
• Install a plugin that contributes something to a freestyle job, e.g. timestamper plugin
• create a freestyle job and make use of the plugin (check the Add timestamps to the Console Output) and save the job
• uninstall the plugin
• restart Jenkins
  -> You should now see only the second table with the unreadable data.
• click on Discard unreadable data
  -> Notice about no data should be shown

[SohamJuneja]

@mawinter69 I followed the steps you mentioned and got the correct results :

[janfaracik]

Any thoughts on "No old data" as the panel text? "No old data was found" to me sounds like it failed to find old data.

[SohamJuneja]

@janfaracik yes , No old data seems a better fit to me too. Shall I change it?

[timja]

yes please

[SohamJuneja]

Done

[mawinter69]

Shouldn't this set hasExtra to true?
I think what @krisstern wanted is that there is an explicit initialization of hasExtra to false before the loop over the data. Afaik this is not explicitly necessary as an unset variable is evaluated to false, but for clarity this would be better.