-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-75136] Show 'Unprotected URLs' description #10151
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
core/src/main/resources/hudson/security/LegacySecurityRealm/config.groovy
Outdated
Show resolved
Hide resolved
I don't think this change needs to be documented in the changelog. That said, as general advice: this proposed changelog entry is not very helpful for readers lacking the context of this PR. Changelog entries should be able to stand by themselves. So something like "in the inline description of the Whatever security realm" at a minimum would be useful here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
See JENKINS-75136.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist