Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75136] Show 'Unprotected URLs' description #10151

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

apuig
Copy link
Contributor

@apuig apuig commented Jan 14, 2025

See JENKINS-75136.

Testing done

Screenshot from 2025-01-14 14-53-11

<div class="jenkins-form-description">These URLs (and URLs starting with these prefixes plus a /) should require no authentication. If possible, configure your container to pass these requests straight to Jenkins without requiring login.</div>

Proposed changelog entries

  • Show 'Unprotected URLs' description

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Copy link

welcome bot commented Jan 14, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases bug For changelog: Minor bug. Will be listed after features labels Jan 14, 2025
@daniel-beck daniel-beck added the skip-changelog Should not be shown in the changelog label Jan 15, 2025
@daniel-beck
Copy link
Member

Show 'Unprotected URLs' description

I don't think this change needs to be documented in the changelog. That said, as general advice: this proposed changelog entry is not very helpful for readers lacking the context of this PR. Changelog entries should be able to stand by themselves. So something like "in the inline description of the Whatever security realm" at a minimum would be useful here.

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 15, 2025
@krisstern krisstern merged commit 8c33677 into jenkinsci:master Jan 16, 2025
16 checks passed
Copy link

welcome bot commented Jan 16, 2025

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants