Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75163] respect user timezone in historywidget #10177

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mawinter69
Copy link
Contributor

Fixes the date when the user configured timezone differs from the controller timezone.

Controller in GMT+1
With user time zone Etc/GMT-13
Before:
image

After:
image

With User time zone Etc/GMT+12
Before:
image

After:
image

See JENKINS-75163.

Testing done

Interactive testing

Proposed changelog entries

  • Use correct date in History widget when user has configured a dedicated timezone

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Fixes the date when the user configured timezone differs from the
controller timezone.
@mawinter69 mawinter69 changed the title JENKINS-75163 fix date in historywidget JENKINS-75163 respect user timezone in historywidget Jan 18, 2025
@mawinter69 mawinter69 changed the title JENKINS-75163 respect user timezone in historywidget [JENKINS-75163] respect user timezone in historywidget Jan 18, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@timja timja added the bug For changelog: Minor bug. Will be listed after features label Jan 18, 2025
@timja timja requested a review from a team January 18, 2025 18:42
@timja
Copy link
Member

timja commented Jan 18, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 18, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@krisstern krisstern merged commit 9b1fb7d into jenkinsci:master Jan 20, 2025
15 checks passed
@mawinter69
Copy link
Contributor Author

@MarkEWaite proposing to backport this to the LTS candidate

@jplayout
Copy link

Thanks @mawinter69.
We will start the process now.

@MarkEWaite
Copy link
Contributor

Backporting pull request proposed as:

@mawinter69 mawinter69 deleted the JENKINS-75163 branch January 31, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants