Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.sun.solaris:embedded_su4j #10188

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jan 21, 2025

I checked usages of this library and corresponding Jenkins API in both Jenkins and CloudBees sources and binaries, and the only reference I found was https://github.com/jenkinsci/pxe-plugin/blob/201b0c4a99a12856054159a5118cdfa336d557a1/src/main/java/hudson/plugins/pxe/PXE.java#L15 which I think is safe to ignore. From commit 9f620f1 15 years ago:

Still very much experimental. Subject to change. Don't use it.

This experiment has run its course.

Testing done

mvn clean verify -DskipTests

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the removed This PR removes a feature or a public API label Jan 21, 2025
@krisstern
Copy link
Member

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 23, 2025
@krisstern krisstern merged commit b5a5e04 into jenkinsci:master Jan 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback removed This PR removes a feature or a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants