Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75259] Fix tooltip and console link in progessbar of non pipeline jobs in the executors widget #10259

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Feb 11, 2025

#9749 caused that the progress bar was no longer showing the proper timing in the tooltip and linking to the console for jobs based on AbstractProject. That includes most Jenkins jobs except Pipeline jobs. Pipeline jobs continue to show the correct timing and links in the build history.

See JENKINS-75259.

Testing done

started a freesyle, matrix and pipeline job and confirmed that the progress bar has proper tooltip and links to the console for all 3 runs

Proposed changelog entries

  • Fix tooltip and console link in progress bar of jobs in the executors widget.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Feb 11, 2025
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

@Vlatombe I'd like your review on this pull request so that we can have it in a weekly release before the 2.492.2 release candidate is built 19 Feb 2025.

Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 12, 2025
@MarkEWaite MarkEWaite self-assigned this Feb 12, 2025
@krisstern krisstern merged commit f294f55 into jenkinsci:master Feb 13, 2025
15 checks passed
@MarkEWaite MarkEWaite added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants