Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75265] Fix notification for l:task #10261

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Feb 12, 2025

Change #9787 introduced a bug so that the notificationBar was not properly showing with javascript error
This affects e.g. the rebuild and naginator plugins

See JENKINS-75265.

Testing done

verified that when clicking on Rebuild for a run the notification is shown

Proposed changelog entries

  • Fix notification for l:task

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Change jenkinsci#9787 introduced a bug that lead so that the notificationBar was not
properly showing with javascript error
@basil basil added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Feb 12, 2025
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 12, 2025
@MarkEWaite MarkEWaite self-assigned this Feb 12, 2025
@krisstern krisstern merged commit cbb8a86 into jenkinsci:master Feb 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants