Remove jCIFS and j-Interop

[jtnord]

jinterop existed soley so we can install Jenkins as a service via the Jenkins UI.

This functionality should not be used, and the windows installer should be used instead.

Removed the jcifs library as it is outdated, no longer maintained and was used only to support launching windows agents via DCOM which no longer works with supported windows versions.

TODO

• PRs to update plugins using Base64 from the jcifs library
  • switch to Base64 to stock java implementation atlassian-bitbucket-server-integration-plugin#428 (7.8k installs)
  • switch to Base64 to stock java implementation testein-plugin#1 (2 installs)
  • https://github.com/jenkinsci/codebeamer-result-trend-updater-plugin (36 installs, unmaintained?)
  • https://github.com/jenkinsci/codebeamer-xunit-importer-plugin (86 installs, unmaintained?)
  • https://github.com/jenkinsci/codebeamer-coverage-publisher-plugin (45 installs, unmaintained?)
• check for any other usage of jcifs
  • https://github.com/jenkinsci/codebeamer-xunit-uploader-plugin (69 installs) (packages jcifs inside a lib)
  • https://github.com/jenkinsci/xldeploy-plugin (641 installs) (packages jcifs-1.3.17)
  • https://github.com/jenkinsci/publish-over-cifs-plugin (3975 installs) (packages jcifs-ng)
  • https://github.com/jenkinsci/windows-slaves-plugin (101k installs - but dead)
• check for any other usage of j-interop

See https://groups.google.com/g/jenkinsci-dev/c/Hj-p1QCntw8

Testing done

Proposed changelog entries

• Remove the ability to install as a Windows service from a running Jenkins install. Users wanting this functionality should instead download and install the MSI package.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
4. There is automated testing or an explanation as to why this change has no tests.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[KalleOlaviNiemitalo]

Perhaps additional things to remove:

• core/src/main/resources/hudson/lifecycle/WindowsInstallerLink/*.properties
• core/pom.xml portion copying jenkins.exe from winsw, unless that is still needed for the MSI package
  

  jenkins/core/pom.xml

  Lines 638 to 646 in c0f6fbe

  	<artifactItem>
  	<groupId>com.sun.winsw</groupId>
  	<artifactId>winsw</artifactId>
  	<version>2.9.0</version>
  	<classifier>net4</classifier>
  	<type>exe</type>
  	<outputDirectory>${project.build.outputDirectory}/windows-service</outputDirectory>
  	<destFileName>jenkins.exe</destFileName>
  	</artifactItem>

[jtnord]

Perhaps additional things to remove:

• core/src/main/resources/hudson/lifecycle/WindowsInstallerLink/*.properties

👍

• core/pom.xml portion copying jenkins.exe from winsw, unless that is still needed for the MSI package

it is used by the WindowsServiceLifecyle to update the exe if Jenkins is updated.
Whilst I question the ability to update Jenkins from within Jenkins if you installed with the MSI (to me if you install with a package you should always upgrade with the package) the functionality does not rely on jcifs or j-interpo so I would say that should live in another PR. Perhaps this is a semi left over from the ability that you could create a service outside the MSI, however it does support more than that.

[abhishekmaity]

/label work-in-progress

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[basil]

The only consumer that still remains relevant is publish-over-cifs, but that publishes its own copy of jcifs-ng that should be unaffected by this removal. (The WMI Windows Agents plugin repository has been archived since last August.)

---

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!