Skip to content

Commit

Permalink
Dialog: Remove overflow: hidden and reposition resize handles
Browse files Browse the repository at this point in the history 
Fixes #10543
Closes gh-1439
  • Loading branch information
@tjvantoll
tjvantoll committed Jan 28, 2015
1 parent 9493839 commit 912eb62
Showing 1 changed file with 37 additions and 6 deletions.
43 changes: 37 additions & 6 deletions themes/base/dialog.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* http://api.jqueryui.com/dialog/#theming
*/
.ui-dialog {
overflow: hidden;
position: absolute;
top: 0;
left: 0;
Expand Down Expand Up @@ -58,12 +57,44 @@
margin: .5em .4em .5em 0;
cursor: pointer;
}
.ui-dialog .ui-resizable-n {
height: 2px;
top: 0;
}
.ui-dialog .ui-resizable-e {
width: 2px;
right: 0;
}
.ui-dialog .ui-resizable-s {
height: 2px;
bottom: 0;
}
.ui-dialog .ui-resizable-w {
width: 2px;
left: 0;
}
.ui-dialog .ui-resizable-se,
.ui-dialog .ui-resizable-sw,
.ui-dialog .ui-resizable-ne,
.ui-dialog .ui-resizable-nw {
width: 7px;
height: 7px;
}
.ui-dialog .ui-resizable-se {
width: 12px;
height: 12px;
right: -5px;
bottom: -5px;
background-position: 16px 16px;
right: 0;
bottom: 0;
}
.ui-dialog .ui-resizable-sw {
left: 0;
bottom: 0;
}
.ui-dialog .ui-resizable-ne {
right: 0;
top: 0;
}
.ui-dialog .ui-resizable-nw {
left: 0;
top: 0;
}
.ui-draggable .ui-dialog-titlebar {
cursor: move;
Expand Down

5 comments on commit 912eb62

@mlchevallier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes should use ".ui-dialog>.ui-resizable-xx" selector instead of ".ui-dialog .ui-resizable-xx", otherwise they overwrite the default size and position of the handle of any resizable widget we use inside a dialog for any kind of purposes. Sounds like an issue for me.

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Would you mind filing a ticket and even a PR? Thanks.

@mlchevallier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the first time for me and I'm not sure how to name my ticket or a PR, and how to express it nicely. Would you mind helping me with that? Thanks for your help.

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Lots of projects on GitHub have documented contribution guidelines, which you can find in the root of the repository. Check out jQuery UI's CONTRIBUTING.md for details on how to submit a ticket and a PR. Feel free to continue posting here if you have more questions or need any help.

@mlchevallier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your support. I read some of the guidelines, but as I'm not familiar with Git, all this stuff seems very complicated to me. You can of course take the lead and the ownership of this issue, I'll feal very more confortable with that! Thanks you very much!

Please sign in to comment.