Tabs: Use standard promise methods for jqXHR #1455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old success(), error() and complete() methods have been deprecated for a while and have been removed in upstream master.
| @@ -843,7 +843,7 @@ return $.widget( "ui.tabs", { | |||
| that._trigger( "load", event, eventData ); | |||
| }, 1 ); | |||
| }) | |||
| .complete(function( jqXHR, status ) { | |||
| .always(function( jqXHR, status ) { | |||
There was a problem hiding this comment.
The arguments that the always function accepts is not the same as complete. jqXHR is only the first argument in the error case; in the success case, it's the last.
|
Ignore Travis, it keeps trying to pull the branch from the wrong repo and failing. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old success(), error() and complete() methods have been deprecated for a
while and have been removed in upstream master.