Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add operator e2e suites #6120

Merged
merged 1 commit into from
Feb 26, 2025
Merged

add operator e2e suites #6120

merged 1 commit into from
Feb 26, 2025

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind flake

What this PR does / why we need it:
add operator e2e suites

Which issue(s) this PR fixes:
Refer to #6042

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Feb 17, 2025
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.08%. Comparing base (00f936b) to head (4e592c1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6120      +/-   ##
==========================================
- Coverage   48.09%   48.08%   -0.02%     
==========================================
  Files         668      668              
  Lines       55327    55327              
==========================================
- Hits        26612    26603       -9     
- Misses      26980    26987       +7     
- Partials     1735     1737       +2
Flag Coverage Δ
unittests 48.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor Author

/retest

@zhzhuang-zju
Copy link
Contributor Author

cc @XiShanYongYe-Chang

@RainbowMango RainbowMango mentioned this pull request Feb 17, 2025
Closed
8 tasks
@zhzhuang-zju
Copy link
Contributor Author

all done~ @XiShanYongYe-Chang

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
Other parts LGTM

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Waiting the CI to pass.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@XiShanYongYe-Chang
Copy link
Member

/cc @RainbowMango

RainbowMango
RainbowMango reviewed Feb 22, 2025
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2025
@zhzhuang-zju
add operator e2e suites
4e592c1 
Signed-off-by: zhzhuang-zju <[email protected]>
RainbowMango
RainbowMango approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@karmada-bot karmada-bot merged commit 01e86ee into karmada-io:master Feb 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

@jwcesign jwcesign Awaiting requested review from jwcesign

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@RainbowMango RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhzhuang-zju @codecov-commenter @XiShanYongYe-Chang @karmada-bot @RainbowMango