Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector): add ratelimiteroptions for policy worker options #6145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CharlesQQ
Copy link
Member

@CharlesQQ CharlesQQ commented Feb 21, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
part of #5790

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 21, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 3.84615% with 75 lines in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (cfebd4d) to head (9ca18f7).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
cmd/controller-manager/app/controllermanager.go 0.00% 37 Missing ⚠️
pkg/detector/detector.go 0.00% 8 Missing ⚠️
pkg/controllers/mcs/service_export_controller.go 0.00% 5 Missing ⚠️
...uota/federated_resource_quota_status_controller.go 0.00% 3 Missing ⚠️
...equota/federated_resource_quota_sync_controller.go 0.00% 3 Missing ⚠️
...targetmarker/hpa_scale_target_marker_controller.go 0.00% 3 Missing ⚠️
pkg/controllers/mcs/endpointslice_controller.go 0.00% 3 Missing ⚠️
...clusterservice/endpointslice_collect_controller.go 0.00% 3 Missing ⚠️
pkg/controllers/cluster/cluster_controller.go 0.00% 2 Missing ⚠️
pkg/controllers/cluster/taint_manager.go 0.00% 2 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6145      +/-   ##
==========================================
- Coverage   48.10%   48.06%   -0.05%     
==========================================
  Files         668      668              
  Lines       55316    55375      +59     
==========================================
+ Hits        26608    26614       +6     
- Misses      26973    27026      +53     
  Partials     1735     1735              
Flag Coverage Δ
unittests 48.06% <3.84%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our workers use the same RateLimiter configuration. Do we not need to consider differentiated configuration?

@CharlesQQ
Copy link
Member Author

Can the discussion be divided into two issues?

  1. Allow users to customize the RateLimiter parameters of all workers
  2. Whether workers of different controllers use different RateLimiter parameters

@XiShanYongYe-Chang
Copy link
Member

I agree. let's take the first step.

Would you please confirm that the other controllers have been added with RateLimiter as well?

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
@CharlesQQ CharlesQQ force-pushed the rate-limit-fix branch 3 times, most recently from c09ac70 to dbc06d0 Compare February 25, 2025 03:35
@CharlesQQ
Copy link
Member Author

Would you please confirm that the other controllers have been added with RateLimiter as well?

I add RateLimiter for other controllers @XiShanYongYe-Chang

EventRecorder record.EventRecorder
client.Client // used to operate Work resources.
EventRecorder record.EventRecorder
RatelimiterOptions ratelimiterflag.Options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RatelimiterOptions -> RateLimiterOptions

@XiShanYongYe-Chang
Copy link
Member

Hi @CharlesQQ, the CI is failed.

@CharlesQQ
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants