-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(detector): add ratelimiteroptions for policy worker options #6145
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6145 +/- ##
==========================================
- Coverage 48.10% 48.06% -0.05%
==========================================
Files 668 668
Lines 55316 55375 +59
==========================================
+ Hits 26608 26614 +6
- Misses 26973 27026 +53
Partials 1735 1735
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6f19cc4
to
cce5325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All our workers use the same RateLimiter configuration. Do we not need to consider differentiated configuration?
Can the discussion be divided into two issues?
|
I agree. let's take the first step. Would you please confirm that the other controllers have been added with RateLimiter as well? |
cce5325
to
28ed1c8
Compare
c09ac70
to
dbc06d0
Compare
I add RateLimiter for other controllers @XiShanYongYe-Chang |
EventRecorder record.EventRecorder | ||
client.Client // used to operate Work resources. | ||
EventRecorder record.EventRecorder | ||
RatelimiterOptions ratelimiterflag.Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RatelimiterOptions -> RateLimiterOptions
pkg/controllers/hpascaletargetmarker/hpa_scale_target_marker_controller.go
Outdated
Show resolved
Hide resolved
dbc06d0
to
f2490ce
Compare
Hi @CharlesQQ, the CI is failed. |
Signed-off-by: chang.qiangqiang <[email protected]>
f2490ce
to
9ca18f7
Compare
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #5790
Special notes for your reviewer:
Does this PR introduce a user-facing change?: