Contribute core/v1 and apps/v1 CRDs for all useful resources
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,63 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can you add a doc in contrib/crds that describes how these were created and how to reporduce?
There was a problem hiding this comment.
Readme.md added in the last force push
There was a problem hiding this comment.
I also added a shell script to regenerate the CRDs if necessary
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
davidfestal
force-pushed
the
contrib-core-and-apps-crds
branch
from
5710ff3 to
ec166b6
Compare
Signed-off-by: David Festal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes CRDs for useful legacy scheme resources (
Pods,Deployments) to be added in the KCP control plane.This is mainly to be able to start using KCP with meaningful resources, even before having implemented:
These CRDs have been generated from the related Kube APIs through the
kubebuildercontroller-gentool.However, before the generation, the types had to be fixed in order to:
kubebuilderannotation such asgroupName, sub-resource-related annotations, ...listTypeandlistMapKeysannotations whereverpatchStrategyandpatchergeKeywas used, in order not to loose this precious information, sincepatchStrategyandpatchMergeKeyvendor extensions do not exist in CRD OpenAPI schema.