This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e69292
to
0438258
Compare
Something is removing the labels from the calico-system namespace:
@invidian any pointers? |
Why do we even test |
We just list all the namespaces, exclude the test ones and then do the verification. So we don't have an exclude list per se. |
Who creates |
Signed-off-by: Suraj Deshmukh <[email protected]>
Release Notes: https://github.com/projectcontour/contour/releases/tag/v1.16.0. Signed-off-by: Suraj Deshmukh <[email protected]>
AKS does! I can see all the images in there are from |
I guess we can just test the namespaces we use then. |
0438258
to
953fa80
Compare
invidian
reviewed
Jun 28, 2021
953fa80
to
2f53355
Compare
This commit adds a check to ignore system namespaces like `calico-system` which is created by AKS. Signed-off-by: Suraj Deshmukh <[email protected]>
2f53355
to
5983dba
Compare
invidian
approved these changes
Jun 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/components
Items related to components
area/dependency-update
To label pending updates of upstream projects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
https://github.com/projectcontour/contour/releases/tag/v1.16.0.
Update