Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: add leaderelection metric #1242

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Apr 24, 2023

Ⅰ. Describe what this PR does

Provide Leaderelection metrics for koord-descheduler.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.59 ⚠️

Comparison is base (cc28a7f) 65.49% compared to head (c7def26) 64.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
- Coverage   65.49%   64.91%   -0.59%     
==========================================
  Files         308      312       +4     
  Lines       31927    32660     +733     
==========================================
+ Hits        20911    21200     +289     
- Misses       9484     9914     +430     
- Partials     1532     1546      +14     
Flag Coverage Δ
unittests 64.91% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZiMengSheng ZiMengSheng force-pushed the descheduler_leader branch 2 times, most recently from b2c19c2 to 8ac2966 Compare April 25, 2023 05:57
@koordinator-bot koordinator-bot bot added size/S and removed size/XS labels Apr 25, 2023
@ZiMengSheng ZiMengSheng changed the title koord-descheduler: add leaderelection metrics koord-descheduler: add leaderelection and controller metrics Apr 25, 2023
@ZiMengSheng ZiMengSheng force-pushed the descheduler_leader branch 3 times, most recently from 404cef5 to ac45539 Compare April 25, 2023 09:58
@koordinator-bot koordinator-bot bot added size/XS and removed size/S labels Apr 26, 2023
@eahydra eahydra changed the title koord-descheduler: add leaderelection and controller metrics koord-descheduler: add leaderelection metric Apr 26, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6a6c6dd into koordinator-sh:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants