-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: add some SortFns for arbitration #1625
koord-descheduler: add some SortFns for arbitration #1625
Conversation
Signed-off-by: baowj <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
+ Coverage 65.29% 65.82% +0.52%
==========================================
Files 369 374 +5
Lines 38117 39484 +1367
==========================================
+ Hits 24889 25990 +1101
- Misses 11404 11607 +203
- Partials 1824 1887 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: baowj <[email protected]>
Signed-off-by: baowj <[email protected]>
Signed-off-by: baowj <[email protected]>
1.add func getMigratingJobNum 2.simplify func SortJobsByMigratingNum 3.add test cases Signed-off-by: baowj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, we can optimize the sorters. @baowj-678 please submit new PR to do the optimization.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) Signed-off-by: baowj <[email protected]>
Ⅰ. Describe what this PR does
Some implementations of
SortFn
according to #1454Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test