Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: fix migration controller max unavailable computing algorigthm #2196

Merged

Conversation

songtao98
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #2195

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp September 4, 2024 13:29
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign eahydra after the PR has been reviewed.
You can assign the PR to them by writing /assign @eahydra in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@songtao98 songtao98 changed the title fix descheduler max unavailable computing algorigthm koord-descheduler: fix migration controller max unavailable computing algorigthm Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (aacf585) to head (9f609ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   67.72%   67.69%   -0.03%     
==========================================
  Files         446      446              
  Lines       42695    42697       +2     
==========================================
- Hits        28916    28905      -11     
- Misses      11258    11268      +10     
- Partials     2521     2524       +3     
Flag Coverage Δ
unittests 67.69% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songtao98
Copy link
Contributor Author

/hold

@songtao98
Copy link
Contributor Author

/unhold

@songtao98 songtao98 force-pushed the fix_get_max_unavailable branch from 3c3126a to 9f609ad Compare September 9, 2024 03:00
@hormes
Copy link
Member

hormes commented Sep 9, 2024

/lgtm
/approve

@koordinator-bot koordinator-bot bot merged commit 4f16162 into koordinator-sh:main Sep 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants