Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix exec exit with 126 #446

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Aug 8, 2022

Signed-off-by: Yue Zhang [email protected]

Ⅰ. Describe what this PR does

fix #437

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from honpey and hormes August 8, 2022 03:56
@ZYecho ZYecho changed the title bugfix: fix exec exit with 126 [not merge] bugfix: fix exec exit with 126 Aug 8, 2022
@jasonliu747
Copy link
Member

/hold

@ZYecho ZYecho force-pushed the fix-proxy branch 2 times, most recently from b005cd0 to 902bc27 Compare August 8, 2022 04:08
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #446 (134292d) into main (c18cad0) will increase coverage by 0.23%.
The diff coverage is 84.30%.

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   67.35%   67.58%   +0.23%     
==========================================
  Files         146      147       +1     
  Lines       15391    15842     +451     
==========================================
+ Hits        10366    10707     +341     
- Misses       4253     4345      +92     
- Partials      772      790      +18     
Flag Coverage Δ
unittests 67.58% <84.30%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/server.go 67.46% <ø> (+0.79%) ⬆️
pkg/util/httputil/reverseproxy.go 84.30% <84.30%> (ø)
...dlet/statesinformer/states_noderesourcetopology.go 60.61% <0.00%> (-6.79%) ⬇️
pkg/util/system/cpu_manager_linux.go 0.00% <0.00%> (ø)
pkg/util/system/common_linux.go 59.09% <0.00%> (+5.24%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+9.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZYecho ZYecho force-pushed the fix-proxy branch 2 times, most recently from 806af48 to b4cafca Compare August 9, 2022 09:06
@ZYecho
Copy link
Contributor Author

ZYecho commented Aug 9, 2022

/unhold

@ZYecho ZYecho changed the title [not merge] bugfix: fix exec exit with 126 bugfix: fix exec exit with 126 Aug 9, 2022
@ZYecho ZYecho force-pushed the fix-proxy branch 3 times, most recently from 1120ced to cce0045 Compare August 11, 2022 12:31
@hormes
Copy link
Member

hormes commented Aug 11, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b907e5e into koordinator-sh:main Aug 11, 2022
hormes pushed a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]koord-runtime-proxy failed to proxy exec request without -it option
3 participants