Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: refactor NodeNUMAResource plugin #507

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 21, 2022

Signed-off-by: Joseph [email protected]

Ⅰ. Describe what this PR does

Refactor to support users to better integrate or extend NodeNUMAResource Plugin.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #507 (86b5708) into main (8d05e30) will increase coverage by 0.14%.
The diff coverage is 70.38%.

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   68.00%   68.14%   +0.14%     
==========================================
  Files         153      156       +3     
  Lines       16425    16499      +74     
==========================================
+ Hits        11170    11244      +74     
- Misses       4422     4433      +11     
+ Partials      833      822      -11     
Flag Coverage Δ
unittests 68.14% <70.38%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eduler/plugins/nodenumaresource/cpu_accumulator.go 84.01% <ø> (ø)
.../plugins/nodenumaresource/topology_eventhandler.go 55.78% <55.78%> (ø)
...duler/plugins/nodenumaresource/pod_eventhandler.go 59.15% <59.15%> (ø)
pkg/scheduler/plugins/nodenumaresource/plugin.go 62.44% <59.67%> (-7.68%) ⬇️
.../scheduler/plugins/nodenumaresource/cpu_manager.go 73.21% <73.21%> (ø)
...heduler/plugins/nodenumaresource/cpu_allocation.go 88.63% <88.63%> (ø)
...scheduler/plugins/nodenumaresource/cpu_topology.go 48.27% <100.00%> (+15.24%) ⬆️
...r/plugins/nodenumaresource/cpu_topology_manager.go 100.00% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra force-pushed the refactor_cpu_orchestration_plugin branch 2 times, most recently from c9fd3d5 to 59d6dd4 Compare August 21, 2022 17:44
@eahydra eahydra force-pushed the refactor_cpu_orchestration_plugin branch from 59d6dd4 to 86b5708 Compare August 21, 2022 17:56
@jasonliu747
Copy link
Member

image

@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 25, 2022
@hormes
Copy link
Member

hormes commented Aug 25, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5c5c717 into koordinator-sh:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants