Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add DeviceAllocations and methods #513

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@jasonliu747
Copy link
Member Author

/cc @buptcozy @eahydra @ZYecho

@koordinator-bot koordinator-bot bot requested review from eahydra and ZYecho August 23, 2022 11:58
@koordinator-bot
Copy link

@jasonliu747: GitHub didn't allow me to request PR reviews from the following users: buptcozy.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @buptcozy @eahydra @ZYecho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #513 (0fe561f) into main (256c96c) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   68.04%   67.94%   -0.11%     
==========================================
  Files         153      155       +2     
  Lines       16425    16504      +79     
==========================================
+ Hits        11177    11214      +37     
- Misses       4415     4461      +46     
+ Partials      833      829       -4     
Flag Coverage Δ
unittests 67.94% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/extension/resource.go 16.66% <ø> (ø)
apis/extension/scheduling.go 0.00% <0.00%> (ø)
pkg/runtimeproxy/store/manager.go 56.09% <0.00%> (ø)
pkg/runtimeproxy/utils/utils.go 100.00% <0.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️
pkg/runtimeproxy/resexecutor/cri/pod.go 51.06% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@buptcozy
Copy link
Contributor

/LGTM

@koordinator-bot
Copy link

@buptcozy: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ZYecho
Copy link
Contributor

ZYecho commented Aug 24, 2022

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jasonliu747 jasonliu747 changed the title apis: add DeviceAllocations apis: add DeviceAllocations and methods Aug 24, 2022
@hormes
Copy link
Member

hormes commented Aug 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit afcc49b into koordinator-sh:main Aug 24, 2022
@jasonliu747 jasonliu747 deleted the deviceallocations branch August 24, 2022 12:12
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants