koord-scheduler: fix CPUTopologyManager get&update race condition

[eahydra]

Signed-off-by: Joseph [email protected]

Ⅰ. Describe what this PR does

koord-scheduler: fix CPUTopologyManager get&update race condition

• T1: goroutineA get CPUTopologyOptions and modify
• T1' goroutineB get CPUTopologyOptions, modify and update.
• T2 then goroutineA updates the modified CPUTopologyOptions, the data that be updated by goroutineB is overridden by goroutineB.

Thanks @ZiMengSheng report the issue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[eahydra]

/cc @ZiMengSheng

[koordinator-bot]

@eahydra: GitHub didn't allow me to request PR reviews from the following users: ZiMengSheng.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ZiMengSheng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #555 (6c1a281) into main (e3bccb0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   67.40%   67.36%   -0.05%     
==========================================
  Files         164      164              
  Lines       17381    17385       +4     
==========================================
- Hits        11716    11711       -5     
- Misses       4804     4813       +9     
  Partials      861      861              

Flag	Coverage Δ
unittests	67.36% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...r/plugins/nodenumaresource/cpu_topology_manager.go	100.00% <100.00%> (ø)
.../plugins/nodenumaresource/topology_eventhandler.go	56.70% <100.00%> (+0.91%)	⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go	71.57% <0.00%> (-9.48%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ZiMengSheng]

/lgtm
/approve

[koordinator-bot]

@ZiMengSheng: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ZiMengSheng]

/lgtm

[koordinator-bot]

@ZiMengSheng: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hormes]

/approve

[jasonliu747]

niceeeeeeeeee!
/lgtm

[koordinator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hormes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment