-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: fix errors caused by incorrect lock in ElasticQuota #810
koord-scheduler: fix errors caused by incorrect lock in ElasticQuota #810
Conversation
Signed-off-by: xulinfei.xlf <[email protected]>
Codecov ReportBase: 67.93% // Head: 67.93% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
=======================================
Coverage 67.93% 67.93%
=======================================
Files 216 216
Lines 24372 24372
=======================================
Hits 16556 16556
Misses 6668 6668
Partials 1148 1148
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: xulinfei.xlf [email protected]
Ⅰ. Describe what this PR does
When deleting QuotaGroup, the pod in the QuotaGroup will be moved to defaultQuota, while the background loop will move the defaultQuota to another quotaGroup. The two processes only have readLock constraints, it will result in some errors. So this PR will change the readLock to writeLock to fix the problem.
As the migrate operation is low-frequency, the writeLock will not influence the performance.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test