Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: move pkg/tool/cache to pkg/util/cache #877

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

saintube
Copy link
Member

Signed-off-by: saintube [email protected]

Ⅰ. Describe what this PR does

Move pkg/tool/cache dir to pkg/util/cache.

Ⅱ. Does this pull request fix one issue?

discussed in #844 (comment)

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

/cc @zwzhang0107 @jasonliu747 @FillZpp

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 66.44% // Head: 66.46% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (fd6289e) compared to base (5b240e0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   66.44%   66.46%   +0.01%     
==========================================
  Files         233      233              
  Lines       26523    26523              
==========================================
+ Hits        17624    17628       +4     
+ Misses       7669     7662       -7     
- Partials     1230     1233       +3     
Flag Coverage Δ
unittests 66.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/executor/resource_update_executor.go 29.57% <ø> (ø)
pkg/koordlet/resmanager/resmanager.go 54.33% <ø> (ø)
pkg/koordlet/util/resourceexecutor/executor.go 39.66% <ø> (ø)
pkg/util/cache/expiration_cache.go 75.75% <ø> (ø)
pkg/util/httputil/reverseproxy.go 85.63% <0.00%> (+0.26%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FillZpp
Copy link
Member

FillZpp commented Dec 12, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6e5f565 into koordinator-sh:main Dec 12, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants