-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: move pkg/tool/cache to pkg/util/cache #877
Conversation
Signed-off-by: saintube <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportBase: 66.44% // Head: 66.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 66.44% 66.46% +0.01%
==========================================
Files 233 233
Lines 26523 26523
==========================================
+ Hits 17624 17628 +4
+ Misses 7669 7662 -7
- Partials 1230 1233 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: saintube [email protected]
Ⅰ. Describe what this PR does
Move pkg/tool/cache dir to pkg/util/cache.
Ⅱ. Does this pull request fix one issue?
discussed in #844 (comment)
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test