Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: LoadAware supports custom estimator #989

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Feb 6, 2023

Signed-off-by: Joseph [email protected]

Ⅰ. Describe what this PR does

LoadAware scheduling plugin is based on the factor estimation algorithm to resolve the problem of scheduling a large number of Pods in cold node scenarios. This algorithm is relatively simple, and needs to be able to customize the estimator to achieve a more accurate estimation mechanism.

Now move the factor estimation algorithm to estimator package as default estimator.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 67.50% // Head: 67.51% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (602d4ed) compared to base (65849ae).
Patch coverage: 77.27% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   67.50%   67.51%           
=======================================
  Files         241      243    +2     
  Lines       27982    28007   +25     
=======================================
+ Hits        18889    18908   +19     
- Misses       7793     7798    +5     
- Partials     1300     1301    +1     
Flag Coverage Δ
unittests 67.51% <77.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/loadaware/estimator/types.go 0.00% <0.00%> (ø)
pkg/scheduler/plugins/loadaware/load_aware.go 73.81% <33.33%> (-3.28%) ⬇️
...r/plugins/loadaware/estimator/default_estimator.go 97.91% <97.91%> (ø)
pkg/scheduler/plugins/coscheduling/core/gang.go 77.28% <0.00%> (-0.95%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koord-scheduler: LoadAware support custom estimator koord-scheduler: LoadAware supports custom estimator Feb 7, 2023
@hormes
Copy link
Member

hormes commented Feb 7, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1966065 into koordinator-sh:main Feb 7, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants