Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_ssh: fix for 'Invalid output from MD5 command' #3486

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

pestophagous
Copy link
Contributor

I believe that this:

fixes issue #3209

Original credit goes to commenter on the issue: #3209 (comment)

Locally I am using this change and it fixes the problem.

@pestophagous
Copy link
Contributor Author

I really hope this fix (or any fix for the minor bug) can be merged, because I very much want to use the only-copy-when-necessary feature. It's a great feature. Thank you for thinking of it in the design of your library.

@pestophagous
Copy link
Contributor Author

@ktbyers thank you for your time and your FOSS service! What's the best way for me to watch the release rollout and know which release-version (for requirements.txt) will contain this fix?

@ktbyers ktbyers merged commit eefa4c4 into ktbyers:develop Aug 26, 2024
20 checks passed
@ktbyers
Copy link
Owner

ktbyers commented Aug 26, 2024

Yeah, I don't know when I will do the next release.

I assume you can just git clone the develop branch or to the specific commit containing that fix?

@pestophagous
Copy link
Contributor Author

Yeah, I don't know when I will do the next release.

I assume you can just git clone the develop branch or to the specific commit containing that fix?

Ah yes. Branch name or commit will work. Thanks a bunch!

@pestophagous
Copy link
Contributor Author

Branch name or commit will work. Thanks a bunch!

In case anyone else lands on this webpage and wants to pip install -r a version that has this linux md5 fix, this is exactly the line that I ended up with in requirements.txt:

netmiko @ git+https://github.com/ktbyers/netmiko@eefa4c4cc3 # can use release semver after next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants