Add missing external types to apply configurations

[astefanutti]

What type of PR is this?

/kind bug

/kind api-change

What this PR does / why we need it:

This PR adds the external types the JobSet API depends on to the code-generator command so the generated client apply configurations are complete and do not rely on "non-apply" types.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add missing external types to apply configurations

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Name	Link
🔨 Latest commit	23d7d0d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/67a9b0b50f94ba00086ba410
😎 Deploy Preview	https://deploy-preview-782--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[astefanutti]

@ahg-g @kannon92 could you please give this a review?

[astefanutti]

@tenzen-y FYI

[kannon92]

Can you explain a bit more about this? What was the motivating factor behind this? I did look at kubeflow and here and I don't really understand what this gives us.

(Code looks good, but I'm unclear on motivation)

[astefanutti]

For Kubeflow Trainer, we are considering moving to using SSA, and for this we need apply configuration for the owned JobSet resources to be "valid".

In general, the apply configurations should not be depending on non-apply configuration structs, otherwise that defeats the purpose of SSA.

[tenzen-y]

For Kubeflow Trainer, we are considering moving to using SSA, and for this we need apply configuration for the owned JobSet resources to be "valid".

In general, the apply configurations should not be depending on non-apply configuration structs, otherwise that defeats the purpose of SSA.

Let me put background here: kubeflow/trainer#2297

[kannon92]

/lgtm

@ahg-g could you take a look also? I'm less sure of SSA but I think the change is fine.

[andreyvelich]

@tenzen-y @astefanutti Do we need to make sure that all objects that we create have external types in apply configs ? For example, PodGroup for Gang-Scheduling with co-scheduling.

[astefanutti]

@andreyvelich you're right. I've checked this and the latest version of the apply configurations for the co-scheduling APIs are already OK as far as I can tell.

[ahg-g]

@jpbetz any thoughts on this?

[ahg-g]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment