Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images: Remove OpenTelemetry. #12024

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Images: Remove OpenTelemetry. #12024

merged 2 commits into from
Sep 29, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Sep 27, 2024 •
edited
Loading

What this PR does / why we need it:

This PR removes the OpenTelemetry image and relevant parts from the chart. The OpenTelemetry module is already built inside the NGINX v1.25 image for a while and we did not yet remove the init module image, yet.

This removal will not change the way OpenTelemetry works. I did not touch the tests, so if everything goes right, they still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

How Has This Been Tested?

E2E tests.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/docs needs-kind Indicates a PR lacks a `kind/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts needs-priority labels Sep 27, 2024
@Gacko Gacko changed the title Pmgyx Images: Remove OpenTelemetry. Sep 27, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 27, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 0d8189f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66f808c5346ae50008a70b1c

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 27, 2024
@Gacko
Copy link
Member Author

Gacko commented Sep 27, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2024
@Gacko
Copy link
Member Author

Gacko commented Sep 27, 2024

/triage accepted
/kind cleanup
/priority backlog
/cc @strongjz @rikatz @tao12345666333 @cpanato

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 28, 2024
This was referenced Sep 28, 2024
Merged
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gacko,cpanato,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko Gacko merged commit 3f6e6ae into kubernetes:main Sep 29, 2024
45 of 46 checks passed
@Gacko Gacko deleted the pmgyx branch September 29, 2024 15:31
Dentrax added a commit to wolfi-dev/os that referenced this pull request Jan 4, 2025
@Dentrax
remove deprecated opentelemetry module
0ec1b99 
ref kubernetes/ingress-nginx#12024

Signed-off-by: Dentrax <[email protected]>
@Dentrax Dentrax mentioned this pull request Jan 4, 2025
Merged
Dentrax added a commit to wolfi-dev/os that referenced this pull request Jan 4, 2025
@Dentrax
remove deprecated opentelemetry module
3a27e40 
ref kubernetes/ingress-nginx#12024

Signed-off-by: Dentrax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@cpanato cpanato cpanato approved these changes

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

@rikatz rikatz Awaiting requested review from rikatz

@strongjz strongjz Awaiting requested review from strongjz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gacko @k8s-ci-robot @tao12345666333 @cpanato